Repository navigation
Release 0.8.0 - #424
Release 0.8.0#424
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68763395f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .prepare("SELECT 1 FROM skills WHERE scope=?1 AND bot_id=?2 AND lower(name)=lower(?3) AND kind IN ('saved','library') AND status IN ('active','removed')")? | ||
| .exists(params![scope, k.bot_id, k.name])?; |
There was a problem hiding this comment.
Preserve chosen-skill provenance across renamed merges
When a saved or library skill is merged into a skill with a different name, subsequent fixes lose the “You chose” notice. skill_merge_propose allows the merged skill to have a new name and records its source IDs in replaces, but this query only checks historical rows with the current name. For example, merging a library skill “Pay safely” into “Pay invoices”, accepting it, and then patching “Pay invoices” produces no notice even though it incorporates a skill the user explicitly chose. Follow the merge ancestry (or persist the chosen provenance) so this approval context survives accepted merges.
Useful? React with 👍 / 👎.
Version 0.8.0: the new app layout (#420), What I noticed and drafting quiet checks (#421), and the context estimate (#422).
crates/mimir-core/src/db/skills.rs, with its test).Checks:
cargo test -p mimir-core --lib(327 passed).After merging: tag
v0.8.0, letrelease.ymldraft the installers, notarize the Mac app locally, publish.🤖 Generated with Claude Code