IS-11318 Move Spinner styles to CSS module and simplify component API.#174
Open
urre wants to merge 1 commit into
Open
IS-11318 Move Spinner styles to CSS module and simplify component API.#174urre wants to merge 1 commit into
urre wants to merge 1 commit into
Conversation
luisgoncalves
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spinnerfromsrc/login-web-app/src/shared/ui/Spinner.tsxinto its own folder (shared/ui/spinner/) alongside a newspinner.module.css, matching theheader/convention already in this app.<style>block (with template-string keyframes) and allstyle={...}attributes from the component. Per-circle animation offsets now live in CSS modifier classes (.delay2,.delay3).width,height, andmodeprops. Size is now fixed at 48×48 and theflex flex-center flex-column justify-centerwrapper (previouslymode="fullscreen") is always rendered — matches what the single call site (HaapiStepperStepUI) was already using.Why
<style>element on every render and used inlinestyleattributes, both of which requirestyle-src 'unsafe-inline'in CSP. Moving to a CSS module produces a linked stylesheet in the Vite production build, so the spinner works under a strict CSP.