Repository navigation
Run UI CI on pull requests that change the desktop app - #35
Merged
Merged
Conversation
The paths filter was `desktop/`, which matches no file, so the workflow never ran on a pull request. Match everything under desktop/, and the workflow itself, as the other workflows do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ESLint ignores eslint.config.js, which the TypeScript project that the typed parser uses doesn't include, so it failed to parse it. - react-refresh/only-export-components is off for the entry points and the router module, which export no components. - Remove an unused import from src/client/command.ts. These 5 errors were there at the fork point, so AGENTS.md no longer mentions them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nine files weren't formatted, so `yarn format:check` failed. Only whitespace and parentheses change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui-ci.yamlfiltered pull requests onpaths: desktop/, which only matches a file literally nameddesktop/, so the workflow has never run: GitHub has no runs of it, although 12 merged PRs changed files underdesktop/. It now matchesdesktop/**, and the workflow file itself, so this PR runs it too.With the workflow running, the problems already on
mainthat it would have caught are fixed here, so it passes:AGENTS.mdmentioned and no longer does):eslint.config.js. The typed TypeScript parser (parserOptions.project) can't parse it, sinceallowJsis off and the TypeScript project doesn't take JavaScript.react-refresh/only-export-componentsis off forsrc/main.tsx,update-window/src/main.tsxandsrc/routes.tsx. They export no components (entry points, and theRoutesandrouterconstants), so when they change Vite reloads the page instead of refreshing components in place, which is fine for them.@tauri-apps/plugin-logimport is removed fromsrc/client/command.ts.yarn format:checkflagged; only whitespace and parentheses change.src/client/command.ts's formatting is in the lint commit, with its import removal; the other 8 are in the Prettier commit.Testing
Locally (Node 22, yarn 1.22.19), after a fresh
yarn install --frozen-lockfile:yarn lint:ci,yarn format:check,yarn types:checkandyarn buildall pass; before these changes, lint and format failed.🤖 Generated with Claude Code