Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts a broad “AWX Operator” → “Ascender Operator” rebrand across documentation, Ansible role metadata, release/publishing scripts, and local development tooling, while keeping the AWX CRDs intact.
Changes:
- Updates many docs/READMEs and Ansible Galaxy role metadata to use “Ascender Operator” and the
ctrliq/ascender-operatorrepo URLs. - Adjusts build/test/support tooling references (Makefile, mkdocs, molecule, nox, publish script) toward the new operator branding and image locations.
- Adds a new OLM ClusterServiceVersion base manifest for
ascender-operator.
Reviewed changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/restore/README.md | Updates restore role requirements branding. |
| roles/restore/meta/main.yml | Updates role metadata description branding. |
| roles/installer/meta/main.yml | Updates role metadata description branding. |
| roles/common/meta/main.yml | Updates role metadata description branding. |
| roles/backup/README.md | Updates backup role requirements branding. |
| roles/backup/meta/main.yml | Updates role metadata description branding. |
| README.md | Renames project title/links and adjusts “Get Involved” text. |
| PROJECT | Renames operator-sdk project name. |
| noxfile.py | Updates doc build docstring branding. |
| molecule/kind/molecule.yml | Updates molecule debug output directory naming. |
| molecule/default/tasks/awx_test.yml | Updates messaging around release env var branding. |
| molecule/default/molecule.yml | Updates molecule debug output directory naming. |
| mkdocs.yml | Updates site/repo branding settings. |
| Makefile | Updates chart naming and namespace default (currently problematic). |
| hack/publish-to-operator-hub.sh | Updates operatorhub publishing script for new image/repo names. |
| docs/user-guide/network-and-tls-configuration.md | Branding updates in user guide. |
| docs/user-guide/database-configuration.md | Branding updates in user guide. |
| docs/user-guide/advanced-configuration/trusting-a-custom-certificate-authority.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/persisting-projects-directory.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/mesh-ingress.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/extra-settings.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/custom-receptor-certs.md | Branding updates in advanced config docs. |
| docs/troubleshooting/debugging.md | Branding updates (currently mismatched with manifests). |
| docs/requirements.in | Branding update in docs requirements comment. |
| docs/README.md | Branding updates in docs build instructions. |
| docs/installation/kind-install.md | Branding updates in kind install instructions. |
| docs/installation/index.md | Branding updates in installation index. |
| docs/installation/basic-install.md | Branding updates in basic install steps/output (currently mismatched with manifests). |
| docs/index.md | Branding updates on docs landing page. |
| docs/contributors-guide/release-process.md | Branding updates in contributor docs. |
| docs/contributors-guide/get-involved.md | Updates contributor “Get involved” contact info. |
| docs/contributors-guide/contributing.md | Updates contributor guide repo links. |
| CONTRIBUTING.md | Branding updates in contributing guidelines. |
| config/manifests/bases/ascender-operator.clusterserviceversion.yaml | Adds new CSV base (currently inconsistent/likely non-functional). |
| CHANGELOG.md | Branding update but also removes older changelog content. |
| ascendermeshingress-demo.yml | Renames demo values (currently invalid K8s names). |
| ascender-demo.yml | Renames demo values (currently invalid K8s names). |
| ansible/instantiate-awx-deployment.yml | Branding update in playbook title. |
| ansible/helm-release.yml | Updates chart repo/name references. |
| .yamllint | Updates yamllint ignore entry for renamed CSV. |
| .helm/starter/README.md | Branding updates in Helm starter documentation. |
Comments suppressed due to low confidence (3)
ascender-demo.yml:5
metadata.namemust be a valid Kubernetes resource name (DNS-1123); capital letters are not allowed, so this example manifest will be rejected by the API server.
ascendermeshingress-demo.yml:7- Both
metadata.nameandspec.deployment_nameshould be valid Kubernetes-style names; the current values contain capital letters and will not work reliably (anddeployment_nameshould match the AWX object name used elsewhere).
CHANGELOG.md:11 - This change removes the historical changelog entries after
0.19.0(e.g., older release notes). Given the PR description is focused on rebranding, this looks like an accidental truncation rather than an intentional branding update.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
- Add ability to deploy with OLM & added logo (Christian Adams) - 86c31a4
- Fix backup & restore issues with special characters in the postgres password (kurokobo) - 589a375
- Use centos:stream8 container where applicable (Shane McDonald)- 12a58d7
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 41 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (1)
CHANGELOG.md:7
- This PR removes all changelog entries prior to 0.19.0. That’s a significant content change unrelated to branding and will make it harder to audit historical behavior across releases—was this truncation intentional for the fork?
This is a list of high-level changes for each release of `ascender-operator`. A full list of commits can be found at `https://github.com/ctrliq/ascender-operator/releases/tag/<version>`.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 52 out of 53 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
CHANGELOG.md:7
- This change truncates the changelog to only include 0.19.0 and removes all older release notes. A branding-only PR shouldn't drop historical release information; please restore the previously documented versions (or move them elsewhere) so the changelog remains complete.
This is a list of high-level changes for each release of `ascender-operator`. A full list of commits can be found at `https://github.com/ctrliq/ascender-operator/releases/tag/<version>`.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
|
Can we merge this? |
Not yet, this is completely untested at this point. We are working on getting the next Ascender released push out, then we will be looking into doing the rebrand across everything. |
blaipr
left a comment
There was a problem hiding this comment.
Read through this against devel — good to see the rebrand started. Most of it is a clean find/replace, but a few lines end up still pointing at upstream AWX, or describing a release flow this repo doesn't actually have. One suggestion below where the fix is mechanical, and a few questions where I didn't want to guess at your intent.
Unrelated to this PR's scope, but same family: SECURITY.md still routes vulnerability reports to security@ansible.com. Happy to send that as a separate PR so it doesn't conflict with this branch.
|
|
||
| [](https://opensource.org/licenses/Apache-2.0) | ||
| [](https://github.com/ansible/awx-operator/actions) | ||
| [](https://github.com/ctrliq/ascender-operator/actions) |
There was a problem hiding this comment.
There's no CI workflow in this repo — the workflows here are Devel, Stage Release and Promote Ascender Operator image — so this badge renders no status.
Worth noting the legacy /workflows/<Name>/badge.svg form renders no status even with a valid workflow name; the /actions/workflows/<file>/badge.svg form works:
| [](https://github.com/ctrliq/ascender-operator/actions) | |
| [](https://github.com/ctrliq/ascender-operator/actions/workflows/devel.yaml) |
| # Ascender Operator Documentation | ||
|
|
||
| The AWX Operator documentation is now available at https://awx-operator.readthedocs.io/ | ||
| The Ascender Operator documentation is now available at https://awx-operator.readthedocs.io/ |
There was a problem hiding this comment.
This still points at the upstream AWX docs site. ascender-operator.readthedocs.io currently 404s, and I couldn't find operator content under docs.ascender-automation.org either, so I didn't want to guess at a replacement.
Is the plan to stand up an RTD site for this repo, or should this point at the docs/ folder here? The same URL is also still in mkdocs.yml as site_url, though repo_url was updated.
|
|
||
| ## Release Process | ||
|
|
||
| The first step is to create a draft release. Typically this will happen in the [Stage Release](https://github.com/ansible/awx/blob/devel/.github/workflows/stage.yml) workflow for AWX and you don't need to do it as a separate step. |
There was a problem hiding this comment.
This link goes to ansible/awx's stage workflow, which looks like a leftover regardless of how the rest of this section resolves.
| After the draft release is created, publish it and the [Promote AWX Operator image](https://github.com/ansible/awx-operator/blob/devel/.github/workflows/promote.yaml) will run, which will: | ||
| After the draft release is created, publish it and the [Promote Ascender Operator image](https://github.com/ctrliq/ascender-operator/blob/devel/.github/workflows/promote.yaml) will run, which will: | ||
|
|
||
| - Publish image to Quay |
There was a problem hiding this comment.
Checking promote.yaml on devel, it retags the staged image to ghcr.io/ctrliq/ascender-operator:latest — I don't see a Quay push or a Helm chart release. Similarly, the molecule smoke-test step in stage.yml is commented out, so "Both of these workflows will run smoke tests" on line 28 doesn't hold right now.
Is the intent to re-enable those (in which case this text is aspirational and fine to leave), or should it describe the current ghcr-only flow? Didn't want to rewrite it out from under your roadmap. Same text is duplicated in docs/contributors-guide/release-process.md.
| This operator was originally built in 2019 by [Jeff Geerling](https://www.jeffgeerling.com) and is now maintained by the Ansible Team | ||
| This operator was originally built in 2019 by [Jeff Geerling](https://www.jeffgeerling.com) and is now maintained by the Ascender Team | ||
|
|
||
| ## Code of Conduct |
There was a problem hiding this comment.
This section and the badge on line 5 still point at the Ansible code of conduct and codeofconduct@ansible.com.
Correction to what I first wrote here: I said this repo had no code of conduct, which was wrong — .github/CODE_OF_CONDUCT.md exists, but it's a one-line pointer to the Ansible Community Code of Conduct, and it isn't touched by this PR. So it's not a question of adopting one; it's that the existing file needs the same decision as this section.
A quick stab at fixing the branding to Ascender without creating breaking changes within the CRD.