Repository navigation
chore(deps): bump Lean toolchain and dependencies to v4.35.0 - #37
Merged
Merged
Conversation
Pin cslib, verso, doc-gen4 and Mathlib to their v4.35.0 tags. Follow Mathlib's renames of Mathlib.Data.Rel and Mathlib.Data.Setoid.Basic, update the expected #print Rel output (Rel now ranges over Sort), and replace the deprecated String.mk with String.ofList. This change was prepared with the assistance of Claude Code (Anthropic); all edits were reviewed by the author.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
End-to-end grading remains unverified on Lean v4.35.0 with the autograder’s older comparator dependency.
No open issues 🎉
What changed in this PR
Updates the CSwL textbook and build infrastructure to Lean v4.35.0.
Changes:
- Updates the toolchain, dependency tags, and locked revisions.
- Adapts chapter code and expected output to upstream API changes.
- Refreshes version documentation and the generated-project fallback.
| File | Description |
|---|---|
| README.md | Updates the Lean version badge. |
| lean-toolchain | Selects Lean v4.35.0. |
| lakefile.toml | Pins direct dependencies to matching release tags. |
| lake-manifest.json | Updates locked dependency revisions and manifest format. |
| CSwLMeta/Save/Project.lean | Updates fallback toolchain and version comment. |
| CSwLCompat.lean | Removes an outdated version comparison from comments. |
| CSwL/Sets.lean | Updates Mathlib imports and expected Rel output. |
| CSwL/InfEngine.lean | Replaces deprecated String.mk with String.ofList. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
lean-toolchaintov4.35.0and pins cslib, verso, doc-gen4 and Mathlib to theirv4.35.0tags (previously cslib, verso and Mathlib were pinned by commit SHA;lake-manifest.jsonstill locks the exact SHAs).Code changes:
CSwL/Sets.lean: follow Mathlib's renames (Mathlib.Data.Rel→Mathlib.Basic.Rel,Mathlib.Data.Setoid.Basic→Mathlib.Order.Setoid.Basic) and update the expected#print Reloutput —Relnow ranges overSort, so students see universe levels here, before#check @Equivalence.CSwL/InfEngine.lean:String.mkis deprecated; useString.ofList(already introduced in IntroL).CSwLMeta/Save/Project.lean.Verified locally:
lake buildandmake all(all four variants) build without errors; thesolutionsproject compiles standalone; thegradingproject and the autograder executable compile.Not verified:
lean4-autograder-mainonly has acomparator-4.33.0branch; it compiles on v4.35.0, but--localneedslandrun(Linux-only) and was not run.moduleto the start of this file". Left as is.This change was prepared with the assistance of Claude Code (Anthropic); all edits were reviewed by the author.