Run mirror-playwright only for same-repo PRs - #75
Merged
Merged
Conversation
The repo is public and arc-workflows is self-hosted, so a fork PR that touches the mirror's paths would run its own code on our runner. A fork token cannot push to ghcr, so the gate loses nothing. Refs cshuttle/Monitoring#1285 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo is public, and
mirror-playwrightruns onpull_requeston the self-hostedarc-workflowsrunners. A fork PR that touchesplaywright-test.ymlormirror-playwright.ymlwould run its own code on our runner. #72 movedselftestPR runs to hosted runners; this was the one PR path left (found in the arc-workflows capture on Monitoring#1285).What
resolvenow runs only forworkflow_dispatchand same-repo PRs.mirrorneedsresolve, so it skips with it.mirror-playwright.yml, so its own run proves a same-repo PR still mirrors.Refs cshuttle/Monitoring#1285
🤖 Generated with Claude Code