feat(market): open listings in the skincraft 3d viewer on the market beta - #415
Open
ykns3 wants to merge 8 commits into
Open
feat(market): open listings in the skincraft 3d viewer on the market beta#415ykns3 wants to merge 8 commits into
ykns3 wants to merge 8 commits into
Conversation
…beta Adds a View in 3D launcher to every listing card in the market beta grid and gives the viewer a listing-details panel (name, wear bar, pattern, name tag, accessories, price with a native buy handoff, restrictions, and description) with prev/next navigation that pages through listings via steam's own infinite-scroll loader.
…evels Replaces the sticker_info markup parsing with the listing's structured asset_accessories, which carry each sticker/charm's own description and slot properties — so rows now show Steam's per-accessory attribute line (Sticker Scrape Level from propertyid 4, Charm Template from 3) with icons served from the economy image CDN like every other item icon.
Replaces the modal header in the market layout with panel-native chrome (skincraft attribution and close up top, paired previous/next pager in the footer), gives accessory rows breathing room, and moves the card launcher into the price row as a plain 3D button sized to Steam's own Buy button.
Injects a View in 3D action beside each dialog pane's Inspect in Game link (skipping accessory inspect links by matching the pane listing's own hex), styled to the native button. Opening dismisses Steam's dialog via its own Escape path first, and the shared launcher behaviour moves into a common base for the card and dialog buttons.
ykns3
marked this pull request as ready for review
August 24, 2026 18:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9def27b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detailslayout mirrors Steam's item dialog (wear bar, properties, accessories, restrictions, description) with Previous/Next, arrow keys, and a Buy hand-off to Steam's native purchase flow.buy-result): the viewer only closes when a native Buy button was clicked, and shows a notice otherwise. The price shown is the buyer total (unPrice + unFee) in Steam's own localized format.Validation
npm test(68 passed)npm run lintnpm run checkformatnpm run buildnpx tsc --noEmitNote
Medium Risk
Introduces a purchase hand-off that programmatically clicks Steam’s Buy button and relies on DOM/fiber scraping for listing data, though listing ids and payloads are strictly validated on the message boundary.
Overview
Adds 3D launchers on the React Market beta (listing card price row and beside the item dialog’s Inspect link), gated on WebGPU like inventory. Opening a listing uses the existing SkinCraft embed with a new
detailslayout: Steam-style listing panel (wear bar, props, accessories, restrictions, description lines), Previous/Next and arrow keys, and optional Buy that hands off to Steam’s native purchase button.Market data path: listings are read from React fiber props, mapped via
skincraft_market_targets(buyer price fromunPrice+unFee, clamped fields), and passed through extended page ↔ content-script messages (request-items/itemsfor infinite-scroll prefetch,buy-listing/buy-resultwith timeout and in-modal error notice). The viewer only closes Buy on confirmed success.Modal/embed: inventory keeps the side grid with scroll-based prefetch; market uses details and proximity-based prefetch. Shared
FLOAT_CONDITION_BANDSfor float bars; inventory target builders generalized so market listings reuse the same item shape and protocol validators.Reviewed by Cursor Bugbot for commit dcfe622. Bugbot is set up for automated code reviews on this repo. Configure here.