fix: propagate GO_TEST_FLAGS to both invocations in go.test.unit - #60
Open
erhancagirici wants to merge 1 commit into
Open
fix: propagate GO_TEST_FLAGS to both invocations in go.test.unit#60erhancagirici wants to merge 1 commit into
go.test.unit#60erhancagirici wants to merge 1 commit into
Conversation
go test is invoked two times in `go.test.unit` target, but only the second invocation has GO_TEST_FLAGS propagated. Also pass for the first invocation. Signed-off-by: Erhan Cagirici <erhan@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test is invoked two times in
go.test.unittarget, but only the second invocation hasGO_TEST_FLAGSpropagated. Also pass for the first invocation to align both runs.This causes test flags like
-timeoutto be ignored for the first run when provided viaGO_TEST_FLAGSmake variable.Fixes #61