wlan: wmi: accept legacy GTK status event prefix - #22
Open
CeRRiLLo89 wants to merge 1 commit into
Open
CeRRiLLo89 wants to merge 1 commit into
CeRRiLLo89 wants to merge 1 commit into
Conversation
firebird11
force-pushed
the
16.0-raphael
branch
from
August 31, 2026 14:37
163140c to
8a36a95
Compare
The GTK status parser requires the complete modern fixed parameter, although it only consumes the prefix through replay_counter. Validate both the event length and the TLV-declared length against the prefix actually consumed by the parser, while continuing to reject truncated events. Tested on raphael: - original kernel: at least 130 GTK length and extraction failures - patched kernel: zero GTK parser and extraction failures - Wi-Fi, suspend/WoW, push, mobile data, calls, KernelSU/SUSFS and rmnet_perf remained operational - no panic, Oops or module-signature failures ICNSS suspend_noirq -EAGAIN remains a separate issue.
CeRRiLLo89
force-pushed
the
backport-gtk-16.0-raphael
branch
from
September 6, 2026 09:56
69324cb to
a641fda
Compare
Contributor
Author
|
Rebuilt the PR branch cleanly on the current Current PR state:
The patch itself is unchanged from the previously validated GTK parser fix.
Additional runtime validation on the official crDroid 20260831 build:
This confirms that the issue is still reproducible on the current official raphael kernel branch. The previous PR head ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21 to the raphael-specific kernel branch actually consumed by the device tree.
The raphael dependency graph selects
android_kernel_xiaomi_sm8150:16.0-raphael, while #21 was merged only into generic16.0. The GTK parser in16.0-raphaelstill contains the legacy-incompatible full-struct length check.This applies the exact #21 parser change with no device-specific adaptation.
Current review state
8a36a953995212a06d0c353fe986f0f2b408762aa641fda9b10e7990156d394e13dace14ae560c73+18/-595a983542a57cd29cfcecb0f9a7fa04e060c4682The branch was rebuilt cleanly after the upstream
16.0-raphaelhistory changed. The stable patch-id is unchanged from the previously validated version.Validation
Current official crDroid
20260831runtime evidence onraphael:4.14.357-openela-perf-g8a36a95399528a36a953995212a06d0c353fe986f0f2b408762aInvalid length for GTK statuswere reproduced in approximately 20 minutes on the unpatched official kernelHistorical exact-build validation of the same patch:
rmnet_perfremained operationalPrevious PR head
69324cbb2778b5e24d13c471ebc890e35bc77150is preserved in the fork asbackup-pr22-pre-rebuild-20260906.Original generic-branch PR: #21