Repository navigation
[6.x] Fix the action menu button that addActionsToChip() builds - #20400
Merged
Merged
Conversation
When a chip has an action container but no menu yet, addActionsToChip() builds a craft-action-menu in JS. Its invoker set appearance="plain" and variant="inherit", neither of which craft-button supports, so the button fell back to the filled variant. On a coloured chip, e.g. an entry whose entry type has a colour, that showed as a dark filled button. Set variant="plain" and the boolean inherit attribute instead, matching the invoker ActionMenu::invokerHtml() renders server-side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
i-just
changed the title
brandonkelly
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a chip has an action container (
slot="suffix") but no menu yet,addActionsToChip()builds acraft-action-menuin JS. Its invoker setappearance="plain"andvariant="inherit", neither of whichcraft-buttonsupports, so the button fell back to the filled variant. On a coloured chip (e.g. an entry whose entry type has a colour) that showed as a dark filled button.This sets
variant="plain"and the booleaninheritattribute instead, matching the invoker thatActionMenu::invokerHtml()renders server-side.The bug came in with #20378 and hasn't been released, so there's no changelog entry.
Screenshots
before:
after:
🤖 Generated with Claude Code