Repository navigation
Fix #14893 recheck removes unselected files results - #8699
Merged
wjakobsson merged 12 commits intoOct 23, 2026
Merged
Conversation
wjakobsson
changed the title
wjakobsson
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wjakobsson
force-pushed
the
fixrecheckingui
branch
5 times, most recently
from
July 16, 2026 12:37
c11bcc4 to
7bb6d4a
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
July 27, 2026 13:19
7bb6d4a to
b047bf5
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
August 4, 2026 13:03
7fa702e to
5ea9731
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
August 17, 2026 09:06
5ea9731 to
585d418
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
2 times, most recently
from
September 1, 2026 13:06
183a3c5 to
4923b63
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
2 times, most recently
from
September 11, 2026 12:10
02924a2 to
8f12219
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
October 21, 2026 11:29
8f12219 to
1b4f5dd
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
October 22, 2026 14:00
1b4f5dd to
dbc1c3c
Compare
wjakobsson
force-pushed
the
fixrecheckingui
branch
from
October 23, 2026 09:07
4544aec to
fba0ced
Compare
wjakobsson
marked this pull request as ready for review
October 23, 2026 10:55
danmar
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated project, 305 files, ~131k results, with build dir.
On main the recheck is fast because it only analyzes the selected files and removes the results of all the other files.
With this PR alone, the first recheck after full analysis reanalyzes almost every file because the hash depends on include order (https://trac.cppcheck.net/ticket/15132). This is fixed in PR #8957, so both should be merged.
This PR also replaces the QStringList used for detecting duplicate results with QSet. Each new result was compared against all earlier ones on the GUI thread, which made the GUI lag a lot for me. Now it's responsive on heavier projects with many warnings, and the single threaded phase at the end of a full analysis went from ~23s to ~2s.