enabled and mitigated performance-avoid-endl clang-tidy warnings#6239
Draft
firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
Draft
enabled and mitigated performance-avoid-endl clang-tidy warnings#6239firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
performance-avoid-endl clang-tidy warnings#6239firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
Conversation
Collaborator
Author
|
There is most likely some explicit flushes to be added to have a good CLI experience. I have not looked into it yet. |
Collaborator
Author
|
It seems the missing flushes somehow expose a bug in the pipe communication in the |
Collaborator
Author
|
I cannot reproduce it outside of the Python test so it must be related to |
| void SymbolDatabase::printVariable(const Variable *var, const char *indent) const | ||
| { | ||
| std::cout << indent << "mNameToken: " << tokenToString(var->nameToken(), mTokenizer) << std::endl; | ||
| std::cout << indent << "mNameToken: " << tokenToString(var->nameToken(), mTokenizer) << '\n'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also help with reducing
valueFlowBailoutIncompleteVarwarnings in our code base.