Repository navigation
Move the Gateway config UI nav back to the top - #165
Merged
Merged
Conversation
The primary nav returns to the header strip as a row between the profile switcher and the right cluster, instead of a column beside the content. The cells, groups, and colors stay as they are. Under 1024px the nav takes its own row below the switcher and actions so all seven links stay visible, and under 710px it shows only icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the primary nav from the left column back into the header, per Cynthia's feedback on #159. No CSS changes: the cells, colors and sizes are what's on master.
Preview
Click through it here: https://runvil-gateway-165.ngrok.app (fake data, nothing real behind it; temporary, so it may be offline)
Under 1024px the links take their own row:
Testing
npm test(211 pass) andtsc --noEmitincrates/gateway/config-ui/uicargo clippy -p gateway-config-uiThe style guide CSS is on hold until the updated mock is ready (see #159).
Part of #143