📝 CodeRabbit Chat: Implement requested code changes#368
Closed
coderabbitai[bot] wants to merge 1 commit into
Closed
📝 CodeRabbit Chat: Implement requested code changes#368coderabbitai[bot] wants to merge 1 commit into
coderabbitai[bot] wants to merge 1 commit into
Conversation
2bndy5
reviewed
Jun 16, 2026
Collaborator
There was a problem hiding this comment.
yikes! We don't need to run clang-format in the new test cases. I was just asking for fixtures that can be diff'd and fed into the new function (compute_format_ranges from our previous discussion on #358) to ensure each case is properly addressed.
I think we're essentially doing a 3-way diff and normalizing the line numbers to the latest patch (from clang-tidy).
Collaborator
|
This PR is an unexpected behavior from a separate discussion. Plus, it is undesirable patch per that same discussion. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes was requested by @2bndy5.
The following files were modified:
cpp-linter/src/clang_tools/clang_format.rs