chore: remove orphan clang-include-cleaner & clang-apply-replacements refs from tests#246
Conversation
… refs from tests PR #242 added clang-include-cleaner and clang-apply-replacements mock data and test cases to the utility layer tests. However, this project only provides pre-commit hooks for clang-format and clang-tidy - no hooks, entry points, or wrapper scripts exist for these tools. The util.py resolution layer is already fully generic and accepts any tool name as a string parameter. Adding mock data and tests for tools that aren't actually used creates confusion and unnecessary maintenance burden without adding any functional value. Removes: 10 dedicated test functions + mock data + parametrize entries
|
Warning Review limit reached
More reviews will be available in 51 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 3 3
Lines 241 241
=======================================
Hits 235 235
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Merging this PR will not alter performance
Comparing Footnotes
|



Summary
PR #242 introduced dynamic PyPI version resolution and also added mock data and test cases for
clang-include-cleanerandclang-apply-replacementsin the utility layer tests. However, this project only provides pre-commit hooks for clang-format and clang-tidy — no hooks, entry points, or wrapper scripts exist for these other tools.The
util.pyresolution layer is already fully generic: it accepts any tool name as a string parameter and resolves versions from PyPI dynamically. Adding mock data and ~160 lines of tests for tools that aren't actually used creates confusion and unnecessary maintenance burden without adding any functional value.Changes
Removes from
tests/test_util.py:MOCK_PYPI_INCLUDE_CLEANERandMOCK_PYPI_APPLY_REPLACEMENTSmock data_pypi_side_effect()test_resolve_version_from_pypi_successandtest_resolve_version_from_pypi_not_foundNet: -161 lines, 35 tests still passing.
Why not keep them?
clang-formatandclang-tidyhooks only. Adding test data for unrelated tools sets false expectations..pre-commit-hooks.yamlentries for these tools.clang-formatandclang-tidytest cases.