[ub] cleanups and feedback from initial reviewers#8739
Draft
notadragon wants to merge 271 commits intocplusplus:ub-ifndrfrom
Draft
[ub] cleanups and feedback from initial reviewers#8739notadragon wants to merge 271 commits intocplusplus:ub-ifndrfrom
notadragon wants to merge 271 commits intocplusplus:ub-ifndrfrom
Conversation
Contributor
Author
|
No need to merge this while work is in progress, but we can point people at this PR to review changes that have happened without re-reading the entire annex. |
Member
|
Converting this pull request to a draft. @notadragon , let me know when this is ready. |
shafik
reviewed
Feb 19, 2026
|
|
||
| \pnum | ||
| \begin{example} | ||
| \begin{codeblock} |
There was a problem hiding this comment.
define A
#define B defined(A)
#if B // Ill-formed no diagnostic required, defined is generated by macro replacement for controlling expression
#endif|
|
||
| \pnum | ||
| \begin{example} | ||
| \begin{codeblock} |
There was a problem hiding this comment.
#include " // Ill-formed no diagnoatic required, does not match one of the two allowable forms
The `E` in the code is actually meant to be a function on an iterator `i`; amend both usages to `E(i)`. This was already done everywhere else (for instance in copy_if or unique_copy).
…eneral' subclauses (cplusplus#7848)
Co-authored-by: jberne4 <jberne4@bloomberg.net>
This UB was removed in Kona 2025.
…d come before full stops
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
from
4971020 to
b2caddb
Compare
wg21bot
added
the
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.