Add TCL statement support (BEGIN, COMMIT, ROLLBACK, SAVEPOINT) - #7
Open
SanjanaBoggaramJ wants to merge 1 commit into
Open
Add TCL statement support (BEGIN, COMMIT, ROLLBACK, SAVEPOINT)#7SanjanaBoggaramJ wants to merge 1 commit into
SanjanaBoggaramJ wants to merge 1 commit into
Conversation
Wires the existing but previously unreferenced tcl_statement rule into statement, and adds the missing ROLLBACK ... TO SAVEPOINT <name> clause per the N1QL transactions docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tcl_statementgrammar rule (BEGIN/START TRANSACTION, COMMIT, ROLLBACK, SAVEPOINT, SET TRANSACTION) intostatement— it was fully defined but never referenced, so none of these parsed before.ROLLBACK ... TO SAVEPOINT <name>clause torollback_transaction, per the transactions docs.Solves the TCL issue mentioned in https://github.com/couchbaselabs/lark_sqlpp/issues/6
Test plan