Gracefully skip compaction during shipping - #7842
Merged
Merged
Conversation
This commit makes ingesters prevented from performing head compaction due to block shipping skip compaction rather than treating it as a failure. The shipping/compaction race is intentional functionality and not an error. With the old functionality, we would get alarms when these two events overlapped, even though there were no issues and compaction succeeded on the next attempt. Signed-off-by: Kyle Stang <kylestng@amazon.com>
kylestang
force-pushed
the
kyle/head-compaction-ship
branch
from
September 16, 2026 22:42
38de1b5 to
a866acc
Compare
alexqyle
approved these changes
Sep 16, 2026
yeya24
approved these changes
Sep 16, 2026
Contributor
|
Test failure doesn't seem related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This commit makes ingesters prevented from performing head compaction due to block shipping skip compaction rather than treating it as a failure.
The shipping/compaction race is intentional functionality and not an error. With the old functionality, we would get alarms when these two events overlapped, even though there were no issues and compaction succeeded on the next attempt.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags