Implement Resource Based Throttling on Querier#7442
Open
eeldaly wants to merge 4 commits intocortexproject:masterfrom
Open
Implement Resource Based Throttling on Querier#7442eeldaly wants to merge 4 commits intocortexproject:masterfrom
eeldaly wants to merge 4 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
friedrichg
requested changes
Apr 24, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Thanks!
We probably need a cortex_querier_rejected_requests_total metric. right?
| query_protection: | ||
| rejection: | ||
| threshold: | ||
| # EXPERIMENTAL: Max CPU utilization that this ingester can reach before |
Member
There was a problem hiding this comment.
Suggested change
| # EXPERIMENTAL: Max CPU utilization that this ingester can reach before | |
| # EXPERIMENTAL: Max CPU utilization that this instance can reach before |
| query_protection: | ||
| rejection: | ||
| threshold: | ||
| # EXPERIMENTAL: Max CPU utilization that this ingester can reach before |
Member
There was a problem hiding this comment.
Suggested change
| # EXPERIMENTAL: Max CPU utilization that this ingester can reach before | |
| # EXPERIMENTAL: Max CPU utilization that this instance can reach before |
| "properties": { | ||
| "cpu_utilization": { | ||
| "default": 0, | ||
| "description": "EXPERIMENTAL: Max CPU utilization that this ingester can reach before rejecting new query request (across all tenants) in percentage, between 0 and 1. monitored_resources config must include the resource type. 0 to disable.", |
Member
There was a problem hiding this comment.
Suggested change
| "description": "EXPERIMENTAL: Max CPU utilization that this ingester can reach before rejecting new query request (across all tenants) in percentage, between 0 and 1. monitored_resources config must include the resource type. 0 to disable.", | |
| "description": "EXPERIMENTAL: Max CPU utilization that this instance can reach before rejecting new query request (across all tenants) in percentage, between 0 and 1. monitored_resources config must include the resource type. 0 to disable.", |
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR implements the already built resource based throttling (#6674) to querier pods to allow for query rejection based on resource utilization.
Query Protection flags are the same as current with
querierprefix:-querier.query-protection.rejection.threshold.cpu-utilization=0.5(0-1) (0 default)-querier.query-protection.rejection.threshold.heap-utilization=0.5(0-1) (0 default)Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags