CI: drop the remotes bootstrap, r-ci installs it now - #19
Merged
Conversation
Added when macos-latest moved to arm64 and r-ci left no `remotes`
behind. Upstream now does: the published run.sh -- the copy the action
actually fetches -- ends its macOS bootstrap with
echo "::group::Adding remotes"
sudo Rscript -e 'install.packages("remotes")'
so the guarded step is a duplicate that only costs a no-op Rscript
call per run. Published and master are byte-identical, so this is the
live copy and not a pending change.
Pure removal: the workflow is byte-identical to its pre-fix parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added when
macos-latestmoved to arm64 and r-ci's macOS bootstrap left noremotesbehind. Upstream owns that now — the publishedrun.sh, which is the copy the action actually fetches, ends its macOS bootstrap with:Published and master are byte-identical, so that is the live copy rather than a pending change. Dirk's
Use a fallback secondary IP addressandAdd -f to let curl fail fastalso cover the curl exit-28 timeout that hit one Linux leg while ours was in place.So the guarded step is now a duplicate that costs a no-op
Rscriptcall per run.Pure removal. 13 deletions, 0 insertions, and the workflow is byte-identical to its pre-fix parent — verified by diffing against the commit before the bootstrap landed, not by eye.
CI on this PR is the confirmation: if the upstream install were not really there, the dependency step would fail exactly as it did before.