fix(sparql): compare computed numeric values without hiding fixture errors - #27
Merged
Merged
Conversation
remiceres
had a problem deploying
to
github-pages
September 10, 2026 15:11 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to corese-stack/corese-core#563 and corese-stack/corese-core#585. Merge only after corese-stack/corese-core#585 has merged into feature/corese-next.
cast-decimaltest running and classify only its known four-source-binding oracle defect as CANT_TELL, never PASSED, INAPPLICABLE or UNTESTED. Require the exact test URI, the decimal computed column, 31 rows, the four exact expected/source terms and agreement on every other binding and row multiplicity. Other mismatches remain FAILED. A corrected upstream oracle passes the normal comparator without special treatment.Why the harness changes are legitimate
Computed numeric values need not have the fixture's arbitrary decimal spelling: see rdf-tests #58, Andy Seaborne and Richard Cyganiak. This does not authorize rewriting stored RDF terms or STRDT results.
In
cast/data.ttl,n07–n10contain0E1/1E0as double/float.cast-decimal.rqprojects?vunchanged, butcast-decimal.srxexpects0.0/1.0in those source bindings. The core preserves the source terms; its four dedicated regression cases verify this. The calculated decimal column and all remaining bindings agree. This exact source-binding defect is distinct from the general formatting discussion; no upstream issue is claimed to resolve it.Validation
./gradlew test: 2,989 tests, consisting of 73 passing harness unit tests and 2,916 official cases.functions: 75/75 pass; cast evaluation: 5 pass + 1 CANT_TELL, with all seven cast syntax cases also passing../gradlew validateEarlReport: 37,474 statements parsed, 15 validation queries passed, JSON/EARL coverage valid.