Fails to parse when body includes something that looks like a scope with new line#48
Fails to parse when body includes something that looks like a scope with new line#48Otard95 wants to merge 3 commits into
Conversation
maybe removing the whitespace here will kick off the CI.
wesleytodd
left a comment
There was a problem hiding this comment.
Changing to request changes since this was failing in CI.
|
Your case is fixed in #55, which I just opened. I lifted your assertions close to verbatim, since The same change covers #54, the nested-paren version of the same bug, where a line like |
I originally came across this when release-please didn't pick up one of our commits. Eventually I tracked it down to this package. I'm creating a PR, mostly to provide the failing test showing the issue. I minimized the test as much as possible, here's a snippet of the original text from the commit that failed to parse, if that's helpful:
The code block is a result of the text in this PR apollographql/federation#2818 ending up in one of our Renovate PR's and subsequently commit body.