Repository navigation
Use Doctrine ORM 3 in dev dependencies and tests - #1324
Open
radimvaculik wants to merge 2 commits into
Open
radimvaculik wants to merge 2 commits into
radimvaculik wants to merge 2 commits into
Conversation
require-dev povoluje doctrine/orm ^2.20.2 || ^3.0 a DoctrineDataSourceTest místo anotací používá atributy, takže běží na obou verzích.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 55.75% 55.75%
=======================================
Files 65 65
Lines 3024 3024
=======================================
Hits 1686 1686
Misses 1338 1338 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Maybe we can drop old Doctrine :-) |
Member
Author
|
OK 🫡 |
Doctrine ORM 2 už není podporovaná, require-dev proto obsahuje jen doctrine/orm ^3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1322. Doctrine ORM 2 is no longer supported. Datagrid itself has no Doctrine requirement and no conflict is added, so ORM 2 may still install for users, but tests now run against ORM 3 only.
Changes
require-dev:doctrine/orm: ^3.0(was^2.20.2).doctrine/annotationsanddoctrine/cache(abandoned, annotations conflict with ORM 3'sdoctrine/lexer ^3).symfony/cache(needed byORMSetupin ORM 3).doctrine/collections: ^2.2.0 || >=3.1.1: 3.0.0–3.1.0 break composite expressions on array items (ArrayCollection::matching() throws a TypeError for composite expressions over array elements doctrine/collections#554, fixed by Another methods on Row callbacks #555, not yet released). Dev-only, users are not affected.DoctrineDataSourceTest: attribute mapping instead of annotations,ORMSetup::createAttributeMetadataConfiguration()+new EntityManager(), SQLite connection withouturl(removed in DBAL 4), native lazy objects on PHP 8.4+ (ORM 3 withsymfony/var-exporter8 has no LazyGhost), typedwalkOrderByItem(OrderByItem): string.phpstan.neon: ignore deprecation ofDoctrine\ORM\Tools\Pagination\Paginator(deprecated in ORM 3.7, its replacementOffsetPaginatordoes not exist in older ORM 3.x).No changes in
src/.Tested locally (PHP 8.5): ORM 3.7.5 + DBAL 4.5 + collections 2.6 – tests, phpstan, cs pass.