Skip to content

fix(cli): distinguish unavailable permission prompts - #13179

Open
primorLee wants to merge 1 commit into
continuedev:mainfrom
primorLee:fix/missing-permission-callback
Open

fix(cli): distinguish unavailable permission prompts#13179
primorLee wants to merge 1 commit into
continuedev:mainfrom
primorLee:fix/missing-permission-callback

Conversation

@primorLee

Copy link
Copy Markdown

Description

Fixes #13178.

When an ask-tier tool call reaches the CLI without an onToolPermissionRequest callback, the CLI now distinguishes the unavailable interactive prompt from an explicit user rejection.

  • represent the missing callback as a dedicated callback_missing denial reason
  • surface Interactive permission prompt unavailable instead of Permission denied by user
  • preserve the existing user-denial and policy-denial behavior

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

Not applicable; this corrects the CLI's permission result and message when no interactive callback is available.

Tests

  • npm test -- src/stream/streamChatResponse.permissions.test.ts
  • prettier --check src/stream/streamChatResponse.helpers.ts src/stream/streamChatResponse.permissions.test.ts src/stream/toolPermissionResult.ts
  • eslint src/stream/streamChatResponse.helpers.ts src/stream/streamChatResponse.permissions.test.ts src/stream/toolPermissionResult.ts

@primorLee
primorLee requested a review from a team as a code owner August 23, 2026 20:04
@primorLee
primorLee requested review from sestinj and removed request for a team August 23, 2026 20:04
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@primorLee

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: 'ask' permission tier silently auto-denies when onToolPermissionRequest callback isn't wired, mislabeled as user denial

1 participant