Dev#1121
Merged
Merged
Conversation
…es remain, cap rows at source count The Add Language button on delta-restart iteration was misbehaving in two ways: 1. It stayed disabled after a single addition when the picked CS locale's code happened to match a source locale code (e.g. CS `fr` mapped to source `fr`, or `ja` → `ja`). `filledMappingCount` had a stale `sourceLocaleLabels.has(k)` filter meant to defend against a fallback-key path in `handleSelectedSourceLocale` that no longer exists (source-first pick now no-ops until CS is picked). The filter was dropping legitimate CS keys, freezing the count at 1, and locking the button after the first Add. 2. The `hasIncompleteRow` gate forced users to fully fill each row before Add Language re-enabled. Removed — users can now spawn multiple empty rows and fill them in any order. Added a hard row cap at `totalSources` so N sources → at most N rows on screen (whether they're mapped yet or not), preventing a user from hammering Add and stranding empty rows that no source can back.
Unblocks the security-sca gate on the CMG-1057/1058 PR — its critical SLA breach was SNYK-JS-ESBUILD-17750822 (esbuild@0.27.3, "Resources downloaded over insecure protocol"), which reached its 15-day SLA threshold while dev's scan hadn't re-run. - upload-api: vitest ^4.0.18 → ^4.1.10 (also @vitest/coverage-v8), pulls in vitest ≥ 4.1.0 which patches CVE-2026-47429 (Vitest UI arbitrary file read/exec) and drops the vulnerable transitive esbuild - ui: refresh package-lock.json so esbuild 0.27.3 → 0.27.7 across all @esbuild/* platform packages (via vite@^7.3.5, no manifest change) No source-code changes; scope-limited to lockfile / dev-dep bumps.
Prior bump (dcbf00b) moved ui's transitive esbuild from 0.27.3 → 0.27.7 by refreshing the lockfile, but SNYK-JS-ESBUILD-17750822 flags every 0.27.x. The Snyk fix lands in 0.28.x. ui's `vite@^7.3.5` pins esbuild in the 0.27 range, so use an npm override to force ^0.28.1 across every consumer of the package (vite@7.3.5 → esbuild override; storybook's transitive esbuild dedupes to the same). No manifest bump for vite — keeps the update surgical and avoids the vite 7 → 8 major (vite 8 dropped esbuild entirely for rolldown, but that's a bigger migration than a security CI unblock warrants).
…s to ensure pagination and footer remain visible on zoom
…e-fix CMG-1057 | Restart Locale Mapper Add Language dropdown
…redTableHeight for responsive table height
…ss and update initial table height calculation
fix: improve responsive behavior of AssetMapper and EntryMapper table…
…no mappable entries
fix: always create content type on test migration, disable Save when …
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira Ticket
MIGRATION-XXXX
📋 PR Type
📝 Description
What changed?
Why?
🧩 Affected Areas
api— Node.js backendui— React frontendupload-api— Upload API serverdocker/docker-compose🧪 How to Test
Expected result:
📸 Screenshots / Recordings
🔗 Related PRs / Dependencies
✅ Author Checklist
feature/,bugfix/, orhotfix/+ 5–30 lowercase chars.env/example.envupdated if new environment variables were addednpm test)README.md/ docs updated if behaviour changed👀 Reviewer Notes