Conversation
0x7f
force-pushed
the
fix-further-fixes
branch
from
September 24, 2026 18:30
110a9d3 to
40a9c5c
Compare
Stop blocking app content when CMP or SDK initialization fails or times out.
Render app content when the first layer times out or reports a load error.
Fail open when authentication or the CMP second layer does not complete.
Keep the consent layer active for authenticated users without an active entitlement.
Remove the consent gate observer during cleanup to prevent stale updates.
Clear the refresh timer on logout/destroy, log out when no refresh token survives a refresh or the token endpoint returns a non-retryable OAuth error, catch initialisation failures instead of leaving an unhandled rejection, and add a timeout to the SDK's fetch calls so a hung request can no longer hang forever.
Fail fast if the static layer HTML never finishes loading, and only start the full initialization timeout once the page has loaded and is waiting to report ready. This distinguishes a network/load failure from a stuck init in error reports, instead of lumping both under one timeout.
Add an optional `timeouts` prop to ContentpassConsentGate covering every timeout-driven operation (CMP init/metadata/consent-status, Contentpass authenticate, the CMP second layer, the Contentpass init watchdog, and the layer's page-load/ready stages), each independently overridable and defaulting to today's behavior when omitted.
0x7f
force-pushed
the
fix-further-fixes
branch
from
September 24, 2026 19:01
b5e83de to
3f62b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutsprop onContentpassConsentGateso integrators can override every timeout-driven stage, defaulting to current behavior when omitted.Test plan
ContentpassConsentGateStartup,Contentpass,fetchWithTimeout,ContentpassSdkProvider)yarn testin CI