test/system: add --command-timeout to skopeo copy calls#1815
Conversation
Fallout from the following: * 61e2c97 * d5daa71 * ecd1ced * 7a5f3ba containers#1811 containers#1815
debarshiray
force-pushed
the
wip/rishi/test-system-libs-helpers-skopeo-copy-timeout
branch
from
df15463 to
6897fc9
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reformats several skopeo copy commands in test/system/libs/helpers.bash to span multiple lines. However, the feedback highlights that the --command-timeout option—which is crucial for preventing indefinite hangs during image copying—is missing from all modified commands. The reviewer recommends adding appropriate timeouts (ranging from 2 to 15 minutes depending on whether the copy is local or over the network) and provides concrete code suggestions for each instance.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
For some reason, calls to 'skopeo copy' to populate the local temporary Docker registry are sometimes hanging indefinitely. Everything was fine on the 28th of May [1]. The problem started with Fedora Rawhide on the 30th of May [2], and spread to Fedora 44 on the 4th of June [3]. Avoid the indefinite hangs and make skopeo(1) fail sooner by using reasonable timeouts - longer for remote network I/O and shorter for local. [1] containers#1799 [2] containers#1798 [3] containers#1769 containers#1811 containers#1815 Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
debarshiray
deleted the
wip/rishi/test-system-libs-helpers-skopeo-copy-timeout
branch
2 participants
For some reason, calls to skopeo copy sometimes hang indefinitely. Avoid
this issue by specifying --command-timeout with reasonable values
(longer for call which must fetch over the network).
#1811