fix(RELEASE-2397): custom ca support in verify-conforma task#3259
fix(RELEASE-2397): custom ca support in verify-conforma task#3259mmalina wants to merge 1 commit intoconforma:mainfrom
Conversation
Refactor trusted-ca volume mounts in verify-conforma-konflux-ta to use directory mount (/mnt/trusted-ca) instead of subPath-based mounts. This is consistent with the mount style used across release-service-catalog tasks and ensures that the task doesn't exit with a failure when the configmap is not present. Remove the redundant trusted-ca volumeMount from the report step, which does not need CA certificate access. Also, update the build-trusted-artifacts image to include a related fix for custom ca handling. Assisted-by: Cursor Signed-off-by: Martin Malina <mmalina@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified trusted CA certificate handling in a Tekton task by removing dedicated volumeMounts, updating the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cc: @querti @simonbaird |
Refactor trusted-ca volume mounts in verify-conforma-konflux-ta to use directory mount (/mnt/trusted-ca) instead of subPath-based mounts. This is consistent with the mount style used across release-service-catalog tasks and ensures that the task doesn't exit with a failure when the configmap is not present. Remove the redundant trusted-ca volumeMount from the report step, which does not need CA certificate access.
Also, update the build-trusted-artifacts image to include a related fix for custom ca handling.
Related build-trusted-artifacts PR: konflux-ci/build-trusted-artifacts#315