Remove junit.version property - #1122
Draft
Na Lou (nlou9) wants to merge 3540 commits into
Draft
Na Lou (nlou9) wants to merge 3540 commits into
Na Lou (nlou9) wants to merge 3540 commits into
Conversation
…to_8_1_x # Conflicts: # pom.xml
Merge Conflict Resolution (from 8.0.x to 8.1.x)
…to_8_2_x # Conflicts: # pom.xml
Merge Conflict Resolution (from 8.1.x to 8.2.x)
# Conflicts: # pom.xml
Merge Conflict Resolution (from 8.2.x to 8.3.x)
# Conflicts: # pom.xml
Merge Conflict Resolution (from 8.3.x to 8.4.x)
# Conflicts: # pom.xml
Merge Conflict Resolution (from 8.4.x to master)
…_to_master # Conflicts: # pom.xml
Merge Conflict Resolution (from 8.4.x to master)
# Conflicts: # pom.xml
Merge Conflict Resolution (from 8.4.x to master)
Deleted the property and the redundant junit:junit dependencyManagement entry it fed -- nothing in this pom declares a bare junit:junit dependency relying on it. confluent-common-bom manages junit:junit at the same value (4.13.2), but downstream migration is nowhere close to done: 21 repos tracked, 0 merged, 5 open, 16 skipped. As with spotbugs-annotations, note that common's own entry pinned scope=test while the BOM's entry has no explicit scope (defaults to compile) -- unverified whether any downstream repo's bare junit:junit dependency relies on inheriting that scope. Opening as a draft pending downstream completion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Downstream migrations or verification are needed before removing the test-scoped entry.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes redundant JUnit 4 version and dependency-management configuration from the Maven POM, relying on the imported BOM.
Changes:
- Removes
junit.version. - Removes the local
junit:junitmanagement entry.
File summaries
| File | Summary |
|---|---|
pom.xml |
Removes redundant JUnit management; downstream consumers require migration or verification to avoid inheriting compile scope. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -399,12 +398,6 @@ | |||
| </dependency> | |||
|
|
|||
| <!--test deps--> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
junit.versionand the redundantjunit:junitdependencyManagemententry it fed — nothing in this pom declares a barejunit:junitdependency relying on it.confluent-common-bommanagesjunit:junitat the same value (4.13.2), but downstream migration is nowhere close to done: 21 repos tracked, 0 merged, 5 open, 16 skipped.common's own entry pinnedscope=test, while the BOM's entry has no explicit scope (defaults tocompile) — same caveat as thespotbugs-annotationscleanup in Remove spotbugs.version property #1114: unverified whether any downstream repo's barejunit:junitdependency relies on inheriting that scope.Test plan