fix(manifest): make commands/mcpServers paths plugin-root-relative - #25
Open
Bryan Thompson (bryan-anthropic) wants to merge 2 commits into
Open
Conversation
Bryan Thompson (bryan-anthropic)
requested a review
from a team
as a code owner
August 6, 2026 21:15
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Merged
1 task
claude plugin validate rejects the leading ../ forms (path-traversal guard); manifest paths resolve from the plugin root, not .claude-plugin/.
Bryan Thompson (bryan-anthropic)
force-pushed
the
fix/plugin-manifest-paths
branch
from
August 11, 2026 01:20
3a3ce0e to
e31bc6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi — while preparing this plugin for Claude marketplace listing, we observed that
claude plugin validaterejects the current manifest:commands: "../.claude/commands"andmcpServers: "../.mcp.json"are interpreted relative to the plugin root (the repository root), not the.claude-plugin/directory, and the leading../trips the CLI's path-traversal guard.This PR makes both paths plugin-root-relative (
./.claude/commands,./.mcp.json);claude plugin validatepasses after the change.One additional observation, not addressed in this PR:
.mcp.jsonlaunchesnode dist/index.js, butdist/is gitignored, so a fresh plugin install has no built server to run. Committing the built output or pointing the server entry at a published package (e.g. vianpx) would let the MCP server start on install.🤖 Generated with Claude Code