update helper: follow renamed ct/ scripts instead of curling a 404 - #22
Open
MickLesk wants to merge 1 commit into
Open
update helper: follow renamed ct/ scripts instead of curling a 404#22MickLesk wants to merge 1 commit into
MickLesk wants to merge 1 commit into
Conversation
A container keeps the slug it was built with. When the ct/ script is renamed the slug goes stale, and run_app_update curled a 404 into bash -c "", which did nothing and still exited 0 -- the update reported success and installed nothing. Reported for pbs, renamed to proxmox-backup-server in ProxmoxVE 0e5f663df. The Alpine merge on 2026-08-18 retired 29 more names the same way, so every container installed from an alpine-* script before that date is affected. Candidates are tried in order and only accepted when the target script really exists, so an unknown slug still fails loudly rather than running some other app's updater. A successful update regenerates /usr/bin/update, so a container is corrected once and stays corrected. Refs community-scripts/ProxmoxVE#16989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
A container keeps the slug it was built with. When a
ct/script is renamed the slug goes stale, andrun_app_updatecurled a 404 intobash -c ""— did nothing, exited 0, reported success.Reported for
pbs(renamed toproxmox-backup-server). The Alpine merge on 2026-08-18 retired 29 more names, so every container from analpine-*script before that date is affected too.Candidates are only accepted when the target script exists, so an unknown slug still fails loudly instead of running another app's updater.
🔗 Related Issue
Refs community-scripts/ProxmoxVE#16989
✅ Prerequisites (X in brackets)
API.txt.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.