Skip to content

fix(webui): strip the scheme before WinHttpConnect - #2

Open
tmark00 wants to merge 1 commit into
cometkim:cometkim/devfrom
tmark00:fix/windows-webui-host
Open

tmark00 wants to merge 1 commit into
cometkim:cometkim/devfrom
tmark00:fix/windows-webui-host

Conversation

@tmark00

@tmark00 tmark00 commented Sep 17, 2026

Copy link
Copy Markdown

Starting the server with --webui fails on Windows before the port is opened:

ninfer-serve: reading the webui version marker failed:
WinHttpConnect(https://huggingface.co) failed: 12005

12005 is ERROR_WINHTTP_UNRECOGNIZED_SCHEME. split_url() cuts the path off the URL but keeps everything before it, so the scheme travels into the host name; WinHttpConnect takes a bare host. Every --webui start hits this, so the auto-download path has probably never run on Windows.

The fix starts the host after :// and measures the path length from there. No other behaviour changes.

Verified on Windows 11 x64, RTX 5090 Laptop (sm_120a), CUDA 13.2, MSVC, Ninja + vcpkg manifest, built from cometkim/dev @ 024f6a94:

  • before: startup aborts with the error above;
  • after: downloading latest webui (version 1789652224694)72 webui files (12 MiB) installed, GET / returns 200 and the UI loads.

Unrelated to this PR, two things I hit on the same laptop while testing that branch, in case they are useful — happy to open separate issues:

  • --kv-dtype hq-e8-2b returns wrong output on this card even at ~20-token prompts (17*23 → 390, 123+456 → 57), while int8 and nvfp4 answer correctly on the same artifact; with --spec mtp it does not start at all (cudaErrorGraphExecUpdateFailure). GB203 has 82 SMs against the desktop part's 170, which is where I would look first.
  • --spec mtp --draft-tokens 6|7 is accepted by the parser ([1,7]) but rejected at startup by kMtpDecodeMaximumDrafts = 5 in src/models/qwen3_5/program/round_buffers.h.

🤖 Generated with Claude Code

The Windows webui downloader passed "https://huggingface.co" as the host name,
because split_url() cut the path off but kept everything before it, scheme
included. WinHttpConnect takes a bare host, so every --webui start died with

    reading the webui version marker failed:
    WinHttpConnect(https://huggingface.co) failed: 12005

12005 is ERROR_WINHTTP_UNRECOGNIZED_SCHEME. The host now starts after "://",
and the path length is measured from there. Verified on Windows 11 + RTX 5090
Laptop: 72 webui files (12 MiB) installed, GET / returns 200.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant