Conversation
The Windows webui downloader passed "https://huggingface.co" as the host name, because split_url() cut the path off but kept everything before it, scheme included. WinHttpConnect takes a bare host, so every --webui start died with reading the webui version marker failed: WinHttpConnect(https://huggingface.co) failed: 12005 12005 is ERROR_WINHTTP_UNRECOGNIZED_SCHEME. The host now starts after "://", and the path length is measured from there. Verified on Windows 11 + RTX 5090 Laptop: 72 webui files (12 MiB) installed, GET / returns 200. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting the server with
--webuifails on Windows before the port is opened:12005isERROR_WINHTTP_UNRECOGNIZED_SCHEME.split_url()cuts the path off the URL but keeps everything before it, so the scheme travels into the host name;WinHttpConnecttakes a bare host. Every--webuistart hits this, so the auto-download path has probably never run on Windows.The fix starts the host after
://and measures the path length from there. No other behaviour changes.Verified on Windows 11 x64, RTX 5090 Laptop (
sm_120a), CUDA 13.2, MSVC, Ninja + vcpkg manifest, built fromcometkim/dev@024f6a94:downloading latest webui (version 1789652224694)→72 webui files (12 MiB) installed,GET /returns 200 and the UI loads.Unrelated to this PR, two things I hit on the same laptop while testing that branch, in case they are useful — happy to open separate issues:
--kv-dtype hq-e8-2breturns wrong output on this card even at ~20-token prompts (17*23→ 390,123+456→ 57), whileint8andnvfp4answer correctly on the same artifact; with--spec mtpit does not start at all (cudaErrorGraphExecUpdateFailure). GB203 has 82 SMs against the desktop part's 170, which is where I would look first.--spec mtp --draft-tokens 6|7is accepted by the parser ([1,7]) but rejected at startup bykMtpDecodeMaximumDrafts = 5insrc/models/qwen3_5/program/round_buffers.h.🤖 Generated with Claude Code