Skip to content

chore: enable removeComments in package tsconfigs - #395

Merged
farnabaz merged 2 commits into
mainfrom
chore/tsconfig-remove-comments
Sep 4, 2026
Merged

chore: enable removeComments in package tsconfigs#395
farnabaz merged 2 commits into
mainfrom
chore/tsconfig-remove-comments

Conversation

@farnabaz

@farnabaz farnabaz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What

Enable "removeComments": true in every publishable package tsconfig.json so TypeScript strips comments from emitted JS during builds.

Why

Published package output should not carry source comments. Scoping this to packages/* keeps examples/docs/root configs unchanged.

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 3, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~9 changed · 🔴 -0 removed · 0 flows · 10 files · commit 5e3c7fc


Architecture

Architecture diagram for comarkdown/comark at 5e3c7fc

9 components touched across 4 lanes.

Open full size


Data flow

No data-flow sequence changed in this PR.


Drill down
Apps & Documentation — 1 component
🟡 CHANGED Bundle Size Test

Vitest test suite verifying packaged artifact sizes and file counts across all workspace packages via npm pack.

UI Framework Adapters — 5 components
🟡 CHANGED Vue 3 Renderer

Vue adapter package, updated to build comment-free JS output and emit declarations separately.

🟡 CHANGED React 19 Renderer

React renderer package, updated to strip comments from compiled output files.

🟡 CHANGED Svelte 5 Renderer

Svelte 5 package, updated with a comment-stripping build pass using a dedicated tsconfig.

🟡 CHANGED Angular Renderer

Angular component adapter, updated to run ngc with removeComments enabled.

🟡 CHANGED Nuxt Module

Nuxt integration module, updated to strip JS comments on build and prepack.

Headless Renderers — 2 components
🟡 CHANGED HTML String Renderer

Headless HTML string renderer, updated to strip TypeScript comments during build.

🟡 CHANGED ANSI Terminal Renderer

Terminal ANSI renderer, updated with comment-free JS compilation and separate declaration emission.

Core Engine — 1 component
🟡 CHANGED Core Parser

Core package build configuration, updated to strip TypeScript comments from generated JavaScript.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it full size on a page of its own, where you can.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Come say hi on Discord

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comark Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-json-render Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-nextjs Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-nuxt Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-svelte Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-sveltekit Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-twoslash Ready Ready Preview Sep 4, 2026 11:15am UTC
comark-vue Ready Ready Preview Sep 4, 2026 11:15am UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@395

@comark/angular

npm i https://pkg.pr.new/@comark/angular@395

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@395

@comark/html

npm i https://pkg.pr.new/@comark/html@395

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@395

@comark/react

npm i https://pkg.pr.new/@comark/react@395

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@395

@comark/vue

npm i https://pkg.pr.new/@comark/vue@395

commit: 5e3c7fc

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✅ Bundle snapshot updated

Committed the new snapshot as 5e3c7fc, verified by re-running the bundle check against it.

GitHub suppresses the events a workflow commit would normally raise, so the ci check above may
still show the earlier failure. Re-run it to refresh the status — the snapshot itself is confirmed green.

Produced by this run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant