Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #124
Issue review
Fit score: 9/10. Relationship
deleteAll()must bind the parent foreign-key value correctly. Substituting a boolean can delete the wrong rows or fail at the database boundary, so this behavior warrants a permanent integration regression.Reasons for
Reasons against
Attempted reproduction
I reproduced the reported shape with a loaded
User, itshasMany( Post )relationship, anduser.posts().deleteAll()on currentnextwith qb14.0.0-beta.3. The bug did not reproduce: only rows bound to user ID 1 were deleted, and another user’s posts remained. No production change was needed, so this PR adds the public-API regression that proves the current behavior.Validation
box run-script formatgit diff --check14.0.0-beta.3