Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
Issue review
Fit score: 8/10. A loaded entity’s primary key is its identity and is used to target writes and relationships. Letting it drift currently produces a particularly dangerous silent result: the save targets the replacement key and may update no row.
Reasons for
Reasons against
Implementation
QuickPrimaryKeyMutationExceptionwhen a loaded entity key differs from its original valueReproduction
The new public-API regression failed before the fix:
findOrFail( 1 ).setId( 2 ).save()did not throw and silently targeted the replacement key.Validation
box run-script formatgit diff --check14.0.0-beta.3