Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46
Issue review
Fit score: 7/10. Query caching is useful for read-heavy Quick applications, and Quick already has the right low-level extension point by forwarding query options to the CFML engine. A built-in entity/relationship identity cache would add substantial invalidation, serialization, and distributed-cache complexity, so this PR deliberately takes the smaller and safer first step.
Reasons for
Reasons against
Implementation
find( id, options )so its query options reachqueryExecuteReproduction
The regression test failed before the fix because
find()calledfirst()without forwarding its options; the captured execution options were empty.Validation
box run-script formatgit diff --check14.0.0-beta.3