Allow isDirty checks for one attribute - #343
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Issue review
Recommendation: 10/10 — implement. Callers frequently need to decide whether one field changed for auditing, conditional side effects, or targeted validation. Requiring a whole-entity dirty result forces manual comparison against internal state. This is a small, backward-compatible API improvement with little downside.
Implementation
isDirtyfirstName) or physical columns (first_name)Test-first evidence
The first regression showed that CFML accepted the extra argument but the old implementation ignored it: after changing
username,isDirty("firstName")incorrectly returned true. The test now covers clean attributes, dirty aliases, dirty physical columns, reverting one field, and whole-entity state.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.