Add entity-aware chunk queries - #342
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
Issue review
Recommendation: 9/10 — implement. Chunking lets applications process large result sets with bounded memory while retaining Quick’s entity behavior. qb already provides reliable pagination mechanics, so Quick only needs to supply its hydration and transformation layer. The tradeoff is offset-based pagination: rows changing during processing can shift between chunks, so callers doing concurrent mutation may prefer a future key-based chunk API.
Implementation
QuickBuilder.chunk(max, callback, options)asQuery/asMementotransformations consistentlyfalseTest-first evidence
The public regression initially errored because the callback received raw structs and
getId()was unavailable. It now receives loaded entities in two-item chunks, verifies ordering, stops after two callbacks, and confirms the returned object is a Quick builder.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.