Test scoped subselects when using all - #336
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Issue review
Recommendation: 8/10 — preserve and test.
.all()and.get()should hydrate the same selected fields; differing behavior is surprising and breaks substitutability. The only downside is a small additional integration test.Reproduction note
The reported failure could not be reproduced on current
nextwithqb@14.0.0-beta.3. AwithLatestPostId()scope followed by.all()hydrates the subselected virtual attribute correctly and executes one query.Implementation
.all()Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.