Support upserts through Quick entity queries - #334
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Issue review
Recommendation: 9/10 — implement. Upsert is a useful bulk persistence primitive and qb now provides the database-specific SQL safely. Quick should expose it without duplicating that compilation logic. The main tradeoffs are that conflict behavior remains database-specific and this is a query operation rather than an entity lifecycle operation, so it does not hydrate entities or fire per-entity persistence events.
Implementation
firstNametofirst_name)matchNullsand constraineddeleteUnmatchedAPIReproduction note
The original missing-method behavior could not be reproduced with
qb@14.0.0-beta.3: Quick already forwardsupsertsuccessfully. The added regression proves the complete database behavior and the wrapper declaration was updated to match the current qb contract.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.