test: distinguish UUID and GUID key types - #332
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Review
Distinguishing CFML UUIDs from standard GUIDs is a good fit for Quick because key generation must match qb's schema column type exactly.
Recommendation: 10/10.
Reasons for
UUIDKeyTypepairs with qbuuid, whileGUIDKeyTypepairs with qbguid.Reasons against
Attempted reproduction
The requested adjustment is already implemented on current
next:UUIDKeyTypeusescreateUUID(), matching qb's 35-characteruuidcolumn.GUIDKeyTypeusescreateGUID(), matching qb's 36-characterguidcolumn.The existing tests only asserted that generated keys were non-numeric, which would not detect the original type ambiguity. This PR verifies the exact UUID/GUID shapes and confirms each generated key can be found again through the normal Quick API.
Validation
git diff --checkpassedqb@14.0.0-beta.3