feat: dispatch custom entity lifecycle events - #330
Open
elpete wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85
Review
Entity-specific lifecycle interception points are a good fit for Quick. They let interceptors express domain intent directly instead of subscribing to every generic Quick event and branching on entity metadata.
Recommendation: 8/10.
Reasons for
onOrderCreated.withoutFiringEvents.Reasons against
Implementation
Entities can define:
variables._dispatchesEvents = { "postInsert" : "onOrderCreated", "postSave" : [ "onOrderSaved", "onAggregateChanged" ] };fireEventcontinues to invoke the entity lifecycle method and announce the standardquick...point first, then announces each configured custom point using the same event data.Test-first evidence
Before implementation, creating the public test entity produced an empty custom-event list instead of
[ "onSongCreated", "onSongSaved", "onMediaSaved" ].The integration test now registers those custom ColdBox points, creates a normal Quick entity, verifies string and array mappings in lifecycle order, and verifies the dispatched entity data.
Validation
git diff --checkpassedqb@14.0.0-beta.3