test: cover updateOrCreate primary-key aliases - #329
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
Review
This is an essential Quick behavior: APIs that accept entity attributes must consistently resolve aliases to physical columns, especially for primary keys.
Recommendation: 10/10.
Reasons for
updateOrCreatecan insert duplicates instead of updating.Reasons against
Attempted reproduction
The repository already contains an issue-specific public test proving
PostAlt.firstOrNew({ id: 1245 })andfirstOrNew({ post_pk: 1245 })both find the same row. That behavior passes on currentnextwithqb@14.0.0-beta.3.I added the missing half of the report:
PostAlt.updateOrCreate({ id: 1245 }, updates). It correctly resolves theidalias to the physicalpost_pkcolumn, updates row 1245, and leaves exactly one matching record. The historical failure therefore no longer reproduces; this PR completes regression coverage.Validation
git diff --checkpassed