feat: support virtual attribute defaults - #328
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Review
This improvement is a good fit for Quick. Virtual projections often represent counts or booleans, and a new entity needs a meaningful value before a query has populated the projection.
Recommendation: 9/10.
Reasons for
falseinstead of an empty string.newEntity()metadata reuse.Reasons against
appendVirtualAttribute( name, true )to exclude an attribute must move that flag to the third argument or use the namedexcludeFromMementoargument.Implementation
appendVirtualAttribute( name, defaultValue, excludeFromMemento = false )on bothBaseEntityandQuickBuilder.newEntity().excludeFromMementocalls.Test-first evidence
Before implementation, the public magic getter returned an empty string for
appendVirtualAttribute( "hasPosts", false ); the new test failed withExpected [false] but received [""].Tests now verify:
newEntity(); andValidation
git diff --checkpassedqb@14.0.0-beta.3