test: support full-null relationship coverage - #312
Merged
Conversation
Collaborator
Author
|
Attempted reproduction: I ran the existing public empty-belongs-to flow on a dedicated Lucee 6.2.8.20 server started with |
elpete
force-pushed
the
test/154-full-null-belongs-to
branch
from
August 22, 2026 23:05
7e10e4b to
d37ca1b
Compare
This was referenced Aug 23, 2026
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154
Issue review
Recommendation: 10/10. Empty relationships must behave correctly with full null support on every supported CFML engine. Null mode is an engine-level compatibility setting, and Quick should preserve the same relationship semantics in either representation.
Reasons for:
Tradeoffs:
Reproduction review
On Lucee 6 with full null support and qb
14.0.0-beta.3, the original public flowgetInstance( "Post" ).find( 7777 ).getAuthor()returns null without throwing. The original Quick/qb exception is fixed upstream.The expanded full-null suite then exposed missing-key assumptions in Quick and several dependencies. Each dependency fix is maintained as a narrow CI patch here until its upstream PR is merged. Every upstream PR includes at least one public-API regression that fails before its fix.
Implementation
FULL_NULLin the test application and enables engine null support.fullNullvalue explicit, including experimental includes, to avoid GitHub expression coercion differences.Dependency baseline
The passing matrix resolved the latest compatible packages available during this run:
8.1.0+347.0.0+192.6.0+514.0.0-beta.3(latestqb@beprerelease)4.0.23.7.0+73.7.15.1.3Upstream dependency PRs
Each PR documents its red/green reproduction, public regression coverage, and local engine validation.
Validation
GitHub Actions run https://github.com/coldbox-modules/quick/actions/runs/32611389233 is green: 26 of 26 jobs passed.
Representative full-null results:
Also:
box run-script format:checkgit diff --check