Skip to content

Add community filter & display to audit logs - #2161

Merged
Oaphi merged 6 commits into
developfrom
0valt/audit_log_community
Sep 27, 2026
Merged

Oaphi merged 6 commits into
developfrom
0valt/audit_log_community

Conversation

@Oaphi

@Oaphi Oaphi commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

This PR adds a community filter & display for audit logs:

community_filter_audit_logs

Also restores the "grant" button for making a user a local admin (seems like it recently got broken by accident)

For now the log's community is always shown - even if the user can only see the current community's logs - does anyone think we should conditionally hide it?

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (9aa6d7d) to head (709dbe0).

Additional details and impacted files
Components Coverage Δ
controllers 77.86% <100.00%> (+0.04%) ⬆️
helpers 85.62% <100.00%> (+0.03%) ⬆️
jobs 79.93% <ø> (ø)
models 93.50% <ø> (ø)
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread app/controllers/admin_controller.rb
@Oaphi
Oaphi requested review from a team, ArtOfCode- and cellio September 25, 2026 11:11

@cellio cellio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and aside from one issue that is probably about how we set up dev environments, not about this change (see separate comment), this works as expected and is a big usability improvement. Scoping to global admins is fine.

Comment thread app/views/admin/_audit_log.html.erb
@cellio

cellio commented Sep 25, 2026

Copy link
Copy Markdown
Member

For now the log's community is always shown - even if the user can only see the current community's logs - does anyone think we should conditionally hide it?

No, I think it's better if the entry shows all the logged info even if this piece is contextually redundant. It's not like we're filling up your screen with a bunch of irrelevant stuff...

@Oaphi
Oaphi requested review from ArtOfCode- and cellio September 25, 2026 20:25

@cellio cellio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community links work as expected now. LGTM.

@Oaphi
Oaphi merged commit 36a1eb3 into develop Sep 27, 2026
14 checks passed
@Oaphi
Oaphi deleted the 0valt/audit_log_community branch September 27, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants