Repository navigation
task description autosave - #98
Merged
Merged
Conversation
Edits save 700 ms after the last keystroke, one request at a time, and once more when the sheet closes or switches tasks. The editor footer shows Saving / Saved / Not saved with Retry; Esc and Done leave the editor and keep the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task descriptions now save as you type
Before this change, a task's description was only saved when you left the editor or clicked Save. Now it saves while you type, so closing the sheet or switching tasks mid-edit no longer depends on a blur event firing. I tested every path below in the browser against a local test instance. Typecheck passes; the desktop app has no unit tests or linter set up.
How it behaves (all in
apps/desktop/src/components/tasks/task-sheet.tsx,EditableDescription)Footer changes
Decision for you: Esc used to throw away the edit; now it keeps the text and closes the editor. Since everything is already saved, I removed Cancel; ⌘Z still undoes inside the editor. If you'd rather keep a way to throw away the whole edit, I can add a "Revert" that restores the text from when editing began.
Tested
Screenshots are in
/Users/danielehrhardt/.godmode/agents/godmode/workspace/task-20-autosave/(autosave-saved.png,autosave-not-saved.png).The commit is
1f6b084, authored as ••••••••, and the branch is already up to date withmain.Task #20 · done by Godmode with Godmode Bot