Preserve legacy Unicode usernames during login - #266
Draft
coder13 wants to merge 2 commits into
Draft
Conversation
PostgreSQL users with legacy non-ASCII usernames must remain readable while the account owner chooses a valid new username. Keep the stored display value and clear the normalized lookup key during unrelated updates, with regression coverage for the login persistence path.
Make the persistence distinction explicit: preserve the username display value and use NULL only for the missing normalized lookup key. Strengthen the regression test to assert both database parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve legacy non-ASCII usernames during unrelated PostgreSQL user updates.
Root cause
PostgreSQL login updates the existing user record. The repository re-ran the new ASCII-only username validator on every write, so accounts with legacy Greek usernames could not complete OAuth login.
Changes
Αλέξανδρος.NULLonly in the separateusername_normalizedlookup field when the legacy value is not valid for new username lookup.Validation
git diff --checkpassed.