fix: defer outdated notification until state machine completes#899
Open
fix: defer outdated notification until state machine completes#899
Conversation
Delay the outdated notification until after initial setup so it does not fire during an in-progress update. Add staleness checks to the update command so it verifies the workspace is still outdated before proceeding.
zenithwolf1000
approved these changes
Apr 18, 2026
zenithwolf1000
left a comment
zenithwolf1000
left a comment
There was a problem hiding this comment.
Provisional ✅ as I'm still learning the codebase, but doesn't seem too complicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markInitialSetupComplete()is called so the notification still fires for workspaces that are outdated after a normal startup.Commands.updateWorkspace()so it verifies the workspace is still outdated before showing the modal and again after the user confirms.latestWorkspaceinstead of the stale closure-captured workspace when the user clicks "Update" in the notification.