Conversation
EhabY
force-pushed
the
ci/migrate-to-pnpm-setup
branch
4 times, most recently
from
September 21, 2026 14:20
e6ab9f7 to
7efc8ac
Compare
Replace pnpm/action-setup + actions/setup-node + manual install step with pnpm/setup v3.0.0 (SHA-pinned), which installs pnpm, provisions Node 22 via pnpm runtime set, and runs pnpm install --frozen-lockfile (require-lockfile: true). Also migrates publish-extension.yaml's standalone setup-node usages. The store cache is a restore/save split around actions/cache, the same policy as the Chromium cache: every branch restores (lockfile-hash key, platform prefix fallback so a dependency bump reuses the rest of the store), only the default branch and releases save. pnpm/setup's own cache: true saves per job per run (pnpm/setup#55, pnpm/setup#56), and v2.1.0's runtime-hashed primary key is never matched by its runtime-less restore probe, so every job saved on every run. Measured on this PR's CI with pnpm/setup caching (setup step, warm): Windows 32-37s vs 56-85s baseline, Linux 8-13s. The split keeps those restore times and drops PR post steps to ~1s. Closes #1119
EhabY
force-pushed
the
ci/migrate-to-pnpm-setup
branch
from
September 22, 2026 08:28
7efc8ac to
892fcc0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1119
A single SHA-pinned
pnpm/setupv3.0.0 step now installs pnpm, provisions Node 22 viapnpm runtime set, and runspnpm install --frozen-lockfile(require-lockfile: true), replacingpnpm/action-setup+actions/setup-node+ a manual install step.publish-extension.yaml's three standalonesetup-nodeusages move over as well, and CONTRIBUTING's Node-version update list now covers both files.Store cache. An
actions/cacherestore/save split, matching the existing Chromium cache policy. Every branch restores (lockfile-hash key with a platform prefix fallback, so a dependency bump reuses the rest of the store); onlymainand releases save.pnpm/setup's owncache: truesaves a full store copy per job per run with no restore-only mode (pnpm/setup#62), and v2.1.0 is worse: its restore probes a runtime-less key while saving under a runtime-hashed one, so saved stores are never matched. Main-only saving follows GitHub's trusted-writer guidance and pnpm/pnpm's own Rust cache (save-cache: ${{ github.ref_name == 'main' }}).Measured on this PR's CI (setup step, warm): Windows 32–37s vs 56–85s baseline, Linux 8–13s. PR post steps drop to ~1s since they no longer save, and duplicate-save warnings are gone by construction. The issue checklist was verified against the pinned source:
--frozen-lockfileenforcement, arch-scoped keys for nativewin32-arm64Node (the ARM64 job lands with #1108's branch).If pnpm/setup#62 ships a restore-only mode, the manual cache steps here collapse back to
cache: trueplus one input.